Yakov, I propose to deprecate current continuous queries and develop new API. This should not break anything. Adding transformers on top of current API will make it total mess.
On Tue, Sep 12, 2017 at 5:39 PM, Николай Ижиков <nizhikov....@gmail.com> wrote: > Yakov. > > > 2. In a new class we still have initial query which uses <K, V> types > which > is questionable. > > After some discussion with a colleague, I think I got your point. > > If I understand your question right: > > Why does someone want to execute an initial query that returns <K, V>? > If one use ContinuousQueryWithTransformer that transform <K, V> to <T>. > > I think you right and we have to transform initialQuery results as well. > > However, at the moment remote transformer supported only for a ScanQuery > [1]: "Currently transformers are supported ONLY for ScanQuery > <https://ignite.apache.org/releases/latest/javadoc/org/ > apache/ignite/cache/query/ScanQuery.html> > ." > > So I propose next: > > 1. Change ContinuousQueryWithTransformer to support only ScanQuery as > initial query. > If in future we will want to support all kinds of Query we can change > from setInitialQuery(ScanQuery) to setInitialQuery(Query) without breaking > API. > 2. Run initial scan query with the same transformer as ContinuousQuery. > > Thoughts? > > [1] https://ignite.apache.org/releases/latest/javadoc/org/ > apache/ignite/IgniteCache.html#query(org.apache.ignite. > cache.query.Query,%20org.apache.ignite.lang.IgniteClosure) > > > 2017-09-12 15:35 GMT+03:00 Yakov Zhdanov <yzhda...@apache.org>: > > > Dmitry, can you please take a look at public API change. > > > > Ticket - https://issues.apache.org/jira/browse/IGNITE-425 > > PR - https://github.com/apache/ignite/pull/2372 > > > > Issues: > > 1. Do you see any other option other than creating separate class? As for > > me I don't. > > 2. In a new class we still have initial query which uses <K, V> types > which > > is questionable. > > > > Igniters, please share your thoughts as well. Public API is the face of > our > > product we need to make it as convenient and consistent as we can. > > > > --Yakov > > > > > > -- > Nikolay Izhikov > nizhikov....@gmail.com >
