Ok. Jira issue for deleting benchmarks code for Ignite 1.9 from separate repo https://issues.apache.org/jira/browse/IGNITE-6227
Ticket for adding page about benchmarking https://issues.apache.org/jira/browse/IGNITE-6278 06.09.2017, 12:18, "Anton Vinogradov" <avinogra...@gridgain.com>: > Aleksei, > > 1) Seems Ignite 1.x have it's own benchmarks (eg. > https://github.com/apache/ignite/tree/ignite-1.9/modules/benchmarks) > So, let's do as Dmitriy proposed. > I'll merge your changes. > > 2) Please create issue to add Benchmarking page to site or readme.io > > On Mon, Sep 4, 2017 at 6:12 PM, Dmitriy Setrakyan <dsetrak...@apache.org> > wrote: > >> Guys, if the code is wrong, let's remove it and add a warning on the >> readme.md clearly stating where to go for the correct benchmarks. >> >> Also, huge +1 for adding benchmarking page to readme. >> >> D. >> >> On Mon, Sep 4, 2017 at 6:37 AM, Aleksei Zaitsev <ign...@alexzaitzev.pro> >> wrote: >> >> > > On Thu, Aug 24, 2017 at 2:02 PM, Dmitriy Setrakyan < >> > dsetrak...@apache.org> >> > > wrote: >> > > >> > >> I would delete all the code from the Yardstick repo to avoid confusion >> > and >> > >> in the description of the repo ask users to download Ignite directly. >> > >> > That's why. But for me it's OK just to add a warning. I think it's not >> > critical, so let's do it in any of the discussed ways. >> > >> > 04.09.2017, 13:42, "Anton Vinogradov" <avinogra...@gridgain.com>: >> > > Aleksei, >> > > >> > > I see a lot of removals, not a warning. >> > > >> > > On Mon, Sep 4, 2017 at 2:18 PM, Aleksei Zaitsev < >> ign...@alexzaitzev.pro> >> > > wrote: >> > > >> > >> >> In this case we'll break a links in blog posts. Let's to add note >> in >> > >> >> readme.md file (about that repository contains outdate >> benchmarks) >> > and >> > >> link >> > >> >> to a repo with actual version of benchmark. >> > >> >> > >> I've already done it in this pull request: https://github.com/ >> > >> apacheignite/yardstick-ignite/pull/6. If it's OK, let's merge it. >> > >> >> > >> 04.09.2017, 13:02, "Anton Vinogradov" <avinogra...@gridgain.com>: >> > >> > Nikolay, >> > >> > >> > >> > Got it. Let's make a Big Warning. >> > >> > >> > >> > But, anyway, we should create special Benchmarking page at site or >> > >> readme.io >> > >> > . >> > >> > >> > >> > On Mon, Sep 4, 2017 at 1:14 PM, Nikolai Tikhonov < >> > ntikho...@apache.org> >> > >> > wrote: >> > >> > >> > >> >> Anton, >> > >> >> >> > >> >> In this case we'll break a links in blog posts. Let's to add note >> in >> > >> >> readme.md file (about that repository contains outdate >> benchmarks) >> > and >> > >> >> link >> > >> >> to a repo with actual version of benchmark. >> > >> >> >> > >> >> On Mon, Sep 4, 2017 at 12:30 PM, Anton Vinogradov <a...@apache.org> >> > >> wrote: >> > >> >> >> > >> >> > Dmitriy, >> > >> >> > >> > >> >> > No, >> > >> >> > We should not keep obsolete repositories to provide urls to >> > correct >> > >> repo >> > >> >> > . >> > >> >> > We should remove this repo and create special Benchmarking page >> at >> > >> site >> > >> >> or >> > >> >> > readme.io. >> > >> >> > >> > >> >> > On Mon, Sep 4, 2017 at 8:03 AM, Dmitriy Setrakyan < >> > >> dsetrak...@apache.org >> > >> >> > >> > >> >> > wrote: >> > >> >> > >> > >> >> > > Igniters, >> > >> >> > > >> > >> >> > > Can we simply update this page with a link to the new repo >> > hosting >> > >> the >> > >> >> > > benchmarks? >> > >> >> > > https://github.com/apacheignite/yardstick-ignite/ >> > >> blob/master/README.md >> > >> >> > > >> > >> >> > > Once we update the page, we can remove the old benchmark code. >> > >> >> > > >> > >> >> > > D. >> > >> >> > > >> > >> >> > > On Thu, Aug 31, 2017 at 5:29 AM, Anton Vinogradov < >> > a...@apache.org> >> > >> >> wrote: >> > >> >> > > >> > >> >> > > > Nikolay, >> > >> >> > > > >> > >> >> > > > 1) It's impossible to use this repo to benchmark Ignite, >> it's >> > >> content >> > >> >> > > > incompatible with latest versions. >> > >> >> > > > It's also a bad idea to copy current bench to this repo, >> > you'll >> > >> need >> > >> >> to >> > >> >> > > > support it. >> > >> >> > > > >> > >> >> > > > 2) Google will reindex removal in 2 weeks and provide >> correct >> > >> link to >> > >> >> > > > Yardstick. >> > >> >> > > > It's also a bad idea to keep outdated repo to provide >> correct >> > >> links >> > >> >> to >> > >> >> > > > current repo. >> > >> >> > > > >> > >> >> > > > 3) We should have Benchmarking page at ignite.apache.org >> > >> >> > > > instead of possible outdated >> > >> >> > > > https://cwiki.apache.org/confluence/display/IGNITE/ >> > >> >> > > > Testing+and+benchmarking >> > >> >> > > > and it should explain how to benchmark Ignite in proper way. >> > >> >> > > > >> > >> >> > > > On Thu, Aug 31, 2017 at 3:16 PM, Nikolai Tikhonov < >> > >> >> > ntikho...@apache.org> >> > >> >> > > > wrote: >> > >> >> > > > >> > >> >> > > > > Guys, >> > >> >> > > > > >> > >> >> > > > > I think this repository useful if I want just run >> benchmark >> > and >> > >> >> play >> > >> >> > > with >> > >> >> > > > > them. Downloading binary distribution (or checkout whole >> > Apache >> > >> >> > Ignite >> > >> >> > > > > source) for this goals doesn't look as clear and effective >> > way >> > >> (on >> > >> >> my >> > >> >> > > > > view). Also github allows to transparently fork this >> > project, >> > >> >> change >> > >> >> > > > > something and share got result with world. As Dmitry >> noticed >> > >> this >> > >> >> > repo >> > >> >> > > > has >> > >> >> > > > > links from google and it's cool and valuable, it means >> that >> > >> users >> > >> >> can >> > >> >> > > > easy >> > >> >> > > > > find our awesome product. Let's just update this >> > repository, I >> > >> >> don't >> > >> >> > > > think >> > >> >> > > > > that is so difficult (seems need just copy files from >> > >> /benchmark >> > >> >> > > folder). >> > >> >> > > > > >> > >> >> > > > > Thoughts? >> > >> >> > > > > >> > >> >> > > > > On Thu, Aug 31, 2017 at 3:00 PM, Anton Vinogradov < >> > >> a...@apache.org> >> > >> >> > > wrote: >> > >> >> > > > > >> > >> >> > > > > > Guys, >> > >> >> > > > > > >> > >> >> > > > > > Lets's just delete this repo. >> > >> >> > > > > > >> > >> >> > > > > > On Thu, Aug 31, 2017 at 10:18 AM, Aleksei Zaitsev < >> > >> >> > > > > ign...@alexzaitzev.pro> >> > >> >> > > > > > wrote: >> > >> >> > > > > > >> > >> >> > > > > > > Exactly, because that benchmarks works only with >> Ignite >> > >> 1.9. So >> > >> >> > not >> > >> >> > > > to >> > >> >> > > > > > > maintain code in two places I deleted it in >> > >> yardstick-ignite >> > >> >> repo >> > >> >> > > and >> > >> >> > > > > > gave >> > >> >> > > > > > > a direct link to up-to-date version of Ignite with >> > >> benchmarks >> > >> >> > > inside. >> > >> >> > > > > > > >> > >> >> > > > > > > 31.08.2017, 02:50, "Dmitriy Setrakyan" < >> > >> dsetrak...@apache.org >> > >> >> >: >> > >> >> > > > > > > > Alexey, I am seeing that some code was removed. Are >> we >> > >> >> offering >> > >> >> > > to >> > >> >> > > > > > users >> > >> >> > > > > > > to >> > >> >> > > > > > > > try the benchmarks shipped with Ignite instead? >> > >> >> > > > > > > > >> > >> >> > > > > > > > On Wed, Aug 30, 2017 at 7:40 PM, Aleksei Zaitsev < >> > >> >> > > > > > ign...@alexzaitzev.pro >> > >> >> > > > > > > > >> > >> >> > > > > > > > wrote: >> > >> >> > > > > > > > >> > >> >> > > > > > > >> Have done just like we discussed. >> > >> >> > > > > > > >> >> > >> >> > > > > > > >> PR: https://github.com/ >> > apacheignite/yardstick-ignite/ >> > >> >> pull/6 >> > >> >> > > > > > > >> >> > >> >> > > > > > > >> 24.08.2017, 02:02, "Dmitriy Setrakyan" < >> > >> >> > dsetrak...@apache.org >> > >> >> > > >: >> > >> >> > > > > > > >> > I would delete all the code from the Yardstick >> > repo to >> > >> >> > avoid >> > >> >> > > > > > > confusion >> > >> >> > > > > > > >> and >> > >> >> > > > > > > >> > in the description of the repo ask users to >> > download >> > >> >> Ignite >> > >> >> > > > > > directly. >> > >> >> > > > > > > >> > >> > >> >> > > > > > > >> > On Wed, Aug 23, 2017 at 7:40 AM, Aleksei Zaitsev >> < >> > >> >> > > > > > > ign...@alexzaitzev.pro >> > >> >> > > > > > > >> > >> > >> >> > > > > > > >> > wrote: >> > >> >> > > > > > > >> > >> > >> >> > > > > > > >> >> Yes, we can, but then we will have to do it >> after >> > >> each >> > >> >> > > > release. >> > >> >> > > > > > > Maybe >> > >> >> > > > > > > >> it's >> > >> >> > > > > > > >> >> better to add information in yardstick repo >> > README, >> > >> that >> > >> >> > > > Apache >> > >> >> > > > > > > Ignite >> > >> >> > > > > > > >> >> contains benchmarks since version 2.0? >> > >> >> > > > > > > >> >> >> > >> >> > > > > > > >> >> 22.08.2017, 16:55, "Dmitriy Setrakyan" < >> > >> >> > > dsetrak...@apache.org >> > >> >> > > > >: >> > >> >> > > > > > > >> >> > On Tue, Aug 22, 2017 at 7:19 AM, Aleksei >> > Zaitsev < >> > >> >> > > > > > > >> ign...@alexzaitzev.pro >> > >> >> > > > > > > >> >> > >> > >> >> > > > > > > >> >> > wrote: >> > >> >> > > > > > > >> >> > >> > >> >> > > > > > > >> >> >> If newer versions of Ignite delivers with >> > >> benchmarks >> > >> >> I >> > >> >> > > > think >> > >> >> > > > > > it's >> > >> >> > > > > > > >> >> >> redundant to support one more project. >> > >> >> > > > > > > >> >> > >> > >> >> > > > > > > >> >> > Well, there are google links. Can we somehow >> > copy >> > >> the >> > >> >> > new >> > >> >> > > > > > > benchmarks >> > >> >> > > > > > > >> into >> > >> >> > > > > > > >> >> > the yardstick repo? >> > >> >> > > > > > > >> >> > >> > >> >> > > > > > > >> >> >> 21.08.2017, 16:17, "Dmitriy Setrakyan" < >> > >> >> > > > > dsetrak...@apache.org >> > >> >> > > > > > >: >> > >> >> > > > > > > >> >> >> > Igniters, >> > >> >> > > > > > > >> >> >> > >> > >> >> > > > > > > >> >> >> > We should either update this repository or >> > >> delete >> > >> >> it. >> > >> >> > > Why >> > >> >> > > > > > have >> > >> >> > > > > > > a >> > >> >> > > > > > > >> >> >> repository >> > >> >> > > > > > > >> >> >> > with outdated benchmarks. >> > >> >> > > > > > > >> >> >> > >> > >> >> > > > > > > >> >> >> > Thoughts? >> > >> >> > > > > > > >> >> >> > >> > >> >> > > > > > > >> >> >> > D. >> > >> >> > > > > > > >> >> >> > >> > >> >> > > > > > > >> >> >> > On Mon, Aug 21, 2017 at 7:14 AM, Aleksei >> > >> Zaitsev < >> > >> >> > > > > > > >> >> ign...@alexzaitzev.pro >> > >> >> > > > > > > >> >> >> > >> > >> >> > > > > > > >> >> >> > wrote: >> > >> >> > > > > > > >> >> >> > >> > >> >> > > > > > > >> >> >> >> Thanks, looks like that's what I need. >> > >> >> > > > > > > >> >> >> >> >> > >> >> > > > > > > >> >> >> >> 21.08.2017, 12:17, "Nikolai Tikhonov" < >> > >> >> > > > > ntikho...@apache.org >> > >> >> > > > > > >: >> > >> >> > > > > > > >> >> >> >> > Hello, >> > >> >> > > > > > > >> >> >> >> > >> > >> >> > > > > > > >> >> >> >> > Yes, this repository contains benchmarks >> > for >> > >> old >> > >> >> > > > Apache >> > >> >> > > > > > > Ignite >> > >> >> > > > > > > >> and >> > >> >> > > > > > > >> >> >> >> > yardstick version. The last versions >> > Apache >> > >> >> Ignite >> > >> >> > > > > > > distributed >> > >> >> > > > > > > >> >> with >> > >> >> > > > > > > >> >> >> >> > benchmarks. You can download there >> > >> >> > > > > > > >> >> >> >> > https://ignite.apache.org/ >> > >> download.cgi#binaries >> > >> >> > and >> > >> >> > > > > found >> > >> >> > > > > > > them >> > >> >> > > > > > > >> >> and >> > >> >> > > > > > > >> >> >> >> > instruction in /benchmarks folder. >> > >> >> > > > > > > >> >> >> >> > >> > >> >> > > > > > > >> >> >> >> > On Mon, Aug 21, 2017 at 10:54 AM, < >> > >> >> > > > > ign...@alexzaitzev.pro >> > >> >> > > > > > > >> > >> >> > > > > > > >> wrote: >> > >> >> > > > > > > >> >> >> >> > >> > >> >> > > > > > > >> >> >> >> >> I am handling with yardstick benchmark >> > >> >> framework >> > >> >> > > for >> > >> >> > > > > > > >> Ignite[1], >> > >> >> > > > > > > >> >> but >> > >> >> > > > > > > >> >> >> the >> > >> >> > > > > > > >> >> >> >> >> latest version available for 1.9. In >> > >> versions >> > >> >> > > 2.0-2.1 >> > >> >> > > > > > were >> > >> >> > > > > > > >> made >> > >> >> > > > > > > >> >> many >> > >> >> > > > > > > >> >> >> >> back >> > >> >> > > > > > > >> >> >> >> >> incompatible changes. Is there any >> newer >> > >> >> version >> > >> >> > > that >> > >> >> > > > > is >> > >> >> > > > > > > >> working >> > >> >> > > > > > > >> >> >> with >> > >> >> > > > > > > >> >> >> >> >> Ignite 2.1 not to do a double job? >> > >> >> > > > > > > >> >> >> >> >> >> > >> >> > > > > > > >> >> >> >> >> [1] https://github.com/ >> > >> >> > > > apacheignite/yardstick-ignite/ >> > >> >> > > > > > > >> > >> >> > > > > > >> > >> >> > > > > >> > >> >> > > > >> > >> >> > > >> > >> >> > >> >
