Makes sense to me. Feel free to create a ticket unless someone else has any objection. However, I think that we should revise other code for such places then. Fixing only this one line doesn't change a lot.
-Val On Thu, Jul 27, 2017 at 12:55 PM, Andrey Kuznetsov <stku...@gmail.com> wrote: > Indeed, "let it crash" approach is better than unclear error in some > indeterminate place later. Here we depend on data from "inpredictable" > source, so assertions are not suitable. > > 27 июля 2017 г. 22:35 пользователь "Valentin Kulichenko" < > valentin.kuliche...@gmail.com> написал: > > Do you suggest to throw an exception instead of assertions? > > -Val >
