Sergey, Looks good to me. Please ask Alex G. to review the implementation part. I’ve taken look at the interfaces only.
— Denis > On May 24, 2017, at 9:04 AM, Sergey Chugunov <[email protected]> > wrote: > > Denis, > > Thanks for your comments, I've addressed them and pushed changes. > > Could you please review one more time? > > Thanks, > Sergey. > > On Wed, May 24, 2017 at 12:20 AM, Denis Magda <[email protected]> wrote: > >> Sergey, >> >> Thanks, reviewed and left the notes in the upsource. >> >> — >> Denis >> >>> On May 23, 2017, at 1:44 AM, Sergey Chugunov <[email protected]> >> wrote: >>> >>> Hello Igniters, >>> >>> I implemented UX improvements for MemoryMetrics and added/clarified some >>> documentation to public API. >>> >>> Please find changes under pull request here >>> <https://github.com/apache/ignite/pull/1988>, for discussions feel free >> to >>> leave comments in upsource review >>> <http://reviews.ignite.apache.org/ignite/review/IGNT-CR-184>. >>> >>> Thanks, >>> Sergey. >> >>
