I think it makes a sense to define factory in IgniteConfiguration, as the
Map<Class, InstanceFactory> which will be ised when deserializing.

Interface example:

public intterface InstanceFactory {
    newInstance(Class clazz, BinaryReader reader);
}

P.S.
About "constructor(BinraryReader reader)" - I think there is no sense,
because it just duplicate readObject method and we can't manage a reference
of new instance.
How about singlton-deserialization?



2017-02-23 10:16 GMT+03:00 Denis Magda <dma...@apache.org>:

> In my understanding the goal is well-defined in the ticket. At the same
> time we have a similar task prepared by Pavel for .NET:
> https://issues.apache.org/jira/browse/IGNITE-3102 <
> https://issues.apache.org/jira/browse/IGNITE-3102>
>
> So, what we need to agree on is how to proceed with the implementation.
> Let us think this over and propose design.
>
> —
> Denis
>
> > On Feb 22, 2017, at 2:41 AM, Vyacheslav Daradur <daradu...@gmail.com>
> wrote:
> >
> > Guys, let's discuss a goal of this task.
> >
> > I need the task specification.
> >
> >
> > 2017-02-22 2:00 GMT+03:00 Denis Magda <dma...@apache.org <mailto:
> dma...@apache.org>>:
> > Replied.
> >
> > —
> > Denis
> >
> > > On Feb 20, 2017, at 3:08 AM, Vladimir Ozerov <voze...@gridgain.com
> <mailto:voze...@gridgain.com>> wrote:
> > >
> > > Hi Vyacheslav,
> > >
> > > Thank you for contribution. I reviewed implementation again and now I
> am in
> > > doubts whether our product would really benefit from it or not. See my
> > > comments in the ticket. I'de prefer Denis Magda to chime in and give
> his
> > > feedback first.
> > >
> > > Vladimir.
> > >
> > > On Wed, Feb 15, 2017 at 5:00 PM, Vyacheslav Daradur <
> daradu...@gmail.com <mailto:daradu...@gmail.com>>
> > > wrote:
> > >
> > >> Hello everyone.
> > >>
> > >> Please, review implemented solution.
> > >>
> > >> https://issues.apache.org/jira/browse/IGNITE-3422 <
> https://issues.apache.org/jira/browse/IGNITE-3422> - No way to control
> > >> object initialization during deserialization/unmarshalling
> > >>
> > >> ci.tests <http://ci.ignite.apache.org/viewQueued.html?itemId=461054 <
> http://ci.ignite.apache.org/viewQueued.html?itemId=461054>>
> > >>
> >
> >
>
>

Reply via email to