> On Jan 31, 2017, at 4:24 PM, Alexey Kuznetsov <akuznet...@apache.org> wrote: > > Denis, > >>> I would make it transparent for the user giving ability to work with > LOCAL queries as well. How difficult is to support this? > I think it not should be very hard, but I will need some help from our SQL > experts. > >>> Isn’t the goal of this task to support all SQL queries? Don’t get why > you ask about SqlQuery. > I implemented support for SqlFieldsQuery, but in Ignite we have othre > queries: SqlQuery, ScanQuery, TextQuery…. >
Shouldn’t the implementation for SqlQueries be the same as for SqlFieldsQueries? Does it requires additional efforts? I had a feeling that both types of SQL queries will share a single implementation in terms of the APIs you’ve contributed. >>>> As for ScanQuery I would do it as a next step. > Well I think we could go this way. If it will be too hard to do it at once. > > By the way, how about to include this feature in Ignite1.9? Absolutely, if you can complete it by the time of 1.9 code freeze. — Denis > > > On Wed, Feb 1, 2017 at 1:27 AM, Denis Magda <dma...@apache.org> wrote: > >> Hi Alex, >> >>>> 1) Current implementation will collect info and cancel only "TwoStep" >>>> queries. >>>> Should we also support LOCAL queries? >>>> >> >> I would make it transparent for the user giving ability to work with LOCAL >> queries as well. How difficult is to support this? >> >>>> 2) Should we also support SqlQuery / ScanQuery ? >> >> Isn’t the goal of this task to support all SQL queries? Don’t get why you >> ask about SqlQuery. >> As for ScanQuery I would do it as a next step. >> >> The review of the code should be done by Sergi. Let’s give him some time >> to do that. >> >> — >> Denis >> >>> On Jan 31, 2017, at 5:13 AM, Alexey Kuznetsov <akuznet...@apache.org> >> wrote: >>> >>> Any feedback, please? >>> >>> On Mon, Jan 30, 2017 at 9:38 PM, Alexey Kuznetsov <akuznet...@apache.org >>> >>> wrote: >>> >>>> Hi All! >>>> >>>> I prepared first version https://issues.apache.org/ >> jira/browse/IGNITE-4436 >>>> (SQL: create API to collect list of running SQL queries and cancel >> them). >>>> >>>> Please review it and give a feedback: http://reviews.ignit >>>> e.apache.org/ignite/review/IGNT-CR-84 >>>> >>>> But also I have following questions: >>>> 1) Current implementation will collect info and cancel only "TwoStep" >>>> queries. >>>> Should we also support LOCAL queries? >>>> >>>> 2) Should we also support SqlQuery / ScanQuery ? >>>> >>>> >>> >>> >>> -- >>> Alexey Kuznetsov >> >> > > > -- > Alexey Kuznetsov
