Vlad, please see my changes in ignite-642 and comment in the ticket. Alex, can you please take a look at my latest commit as well and provide comments?
--Yakov 2016-04-12 23:47 GMT+03:00 Yakov Zhdanov <yzhda...@apache.org>: > Very good points, Alexey. I will look at this tomorrow and finalize the > changes. > > --Yakov > > 2016-04-12 23:41 GMT+03:00 Alexey Goncharuk <alexey.goncha...@gmail.com>: > >> Guys, >> >> I fixed code style a bit and pushed my changes to the branch. >> >> Couple of questions: >> - I see that some of the Errors caught do not get re-thrown (e.g. if >> interruptAll flag is set). I believe we should at least re-throw OOME in >> any case. >> - readResolve method is missing for CacheLockImpl. The current >> readExternal/writeExternal code uses static stash field. I looked around >> in >> the code and found that IgniteKernal uses localIgnite, while >> GridCacheAdapter uses stash. Which way is the correct one? >> >> > >
