I would better ask contributors to ping committers on the dev list when
a patch is available asking for review.
It can happen that committers missed or forgot to do the review and a
contributor can remind them sending one more email to the dev list.
I don't see anything wrong with this approach. It's an open source
project and most of the people don't keep an eye on new contributions
that have to be released.
PATCH_AVAILABLE stat is a right point. But I won't execute this filter
all the time checking for pending reviews and some of the committers
don't move the ticket to the CLOSED state when everything is merged.
The latter was discussed some time ago there.
--
Denis
On 3/2/2016 6:02 PM, Anton Vinogradov wrote:
Denis,
We have a special status at Ignite JIRA - PATCH AVAILABLE which means that
issue ready to be reviewed.
Currently 59 issues has such status according to
https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
I think we have to add notes that this status can be used only during
waiting of review and we will have no problems with actual "required
review" list in future.
On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh <rsht...@yahoo.com.invalid>
wrote:
I have also asked for review of the following tickets but failed to get a
feedback.
They are not complicated, but I would appreciate a quick review. Thank you!
[IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND
https://issues.apache.org/jira/browse/IGNITE-2563
IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6 addresses
https://issues.apache.org/jira/browse/IGNITE-2416
and a new one
IGNITE-2710 Session not unbind from current request after invoking
request.getSession().invalidate()
https://issues.apache.org/jira/browse/IGNITE-2710
-Roman
On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dma...@gridgain.com>
wrote:
Ignite committers,
There is a number of contributions that have to be reviewed.
Please pick them up basing on your experience and provide your review
notes.
Ignite 2718: Missing ZookeeperIpFinder dependencies
<https://issues.apache.org/jira/browse/IGNITE-2718>
IGNITE-2693: withKeepBinary and non-binary marshallers
<https://issues.apache.org/jira/browse/IGNITE-2693>
IGNITE-2735: Fixes distributed semaphore local node stopping issue.
<https://issues.apache.org/jira/browse/IGNITE-2735>
*IGNITE-642: Implements cache distributed reentrant lock
<https://issues.apache.org/jira/browse/IGNITE-642>
*Regards,
Denis
