+1, the spec change makes sense.

> Make delete counts required to avoid ambiguity w.r.t NULL vs unknown.

If we want to make this change, I think we need to unlink all
the partitions stats files in old snapshots (if it's already calculated
with optional delete counts) when upgrading to V3 table from V1/V2?

On Sat, Feb 1, 2025 at 10:01 AM Anton Okolnychyi <aokolnyc...@gmail.com>
wrote:

> Hi all,
>
> I propose the following updates to our partition stats spec in V3:
>
> - Modify `position_delete_record_count` to include a sum of position
> deletes across position delete files and DVs
> - Keep `position_delete_file_count` to represent the number of position
> delete files (ignoring DVs)
> - Add `dv_count` to represent the number of DVs
> - Make delete counts required to avoid ambiguity w.r.t NULL vs unknown.
>
> Here is the PR with the spec update:
> https://github.com/apache/iceberg/pull/12098
>
> - Anton
>

Reply via email to