Issue is fixed and will be sending out a vote for RC2. Sorry everyone! On Wed, Nov 13, 2024 at 2:50 PM Kevin Liu <kevin.jq....@gmail.com> wrote:
> Hey Matt, > > -1 (non binding) We need a new RC due to the issues below. > > I found a few issues while verifying the RC. > > The first one is minor. The "[2]:" text mentions rc1 but links to rc0. > > The second is blocking. While running the verification script, I found > that the sha256 file contains the wrong content. See the file here [1]. The > file name is wrong in the sha256 file, notice the extra `-rc1` > ``` > 750f4f6593368d6ea4d79559d1491c0dcea1ab0ca6130bdd3401e607d7f837b0 > apache-iceberg-go-0.1.0-rc1-rc1.tar.gz > ``` > I believe this was introduced by a recent PR [2] > > Here's a PR to fix the issue [3], I've verified using my own forked repo. > Sorry for the churn here, I should have tested the previous PR more closely. > > Best, > Kevin Liu > > > [1] https://github.com/apache/iceberg-go/releases/tag/v0.1.0-rc1 > [2] > https://github.com/apache/iceberg-go/commit/8ca0bb7bdf7868bac4aca83f50db047d9bf0277c#diff-2ff8a59693d8d05dd67560f01c2a49d9e05f4b1ccefeb91f8486744532214e44R94 > [3] https://github.com/apache/iceberg-go/pull/202 > > On Wed, Nov 13, 2024 at 8:46 AM Matt Topol <zotthewiz...@gmail.com> wrote: > >> Slight fix to the previous email: the text should say "The source release >> *rc1* is hosted at [2]" >> >> The link is correct, it's only the text that needed to be updated. >> >> On Wed, Nov 13, 2024 at 11:43 AM Matt Topol <zotthewiz...@gmail.com> >> wrote: >> >>> Hi, >>> >>> I would like to propose the following release candidate (RC1) of Apache >>> Iceberg Go version v0.1.0. >>> >>> This release candidate is based on commit: >>> 8ca0bb7bdf7868bac4aca83f50db047d9bf0277c [1] >>> >>> The source release rc0 is hosted at [2]. >>> >>> Please download, verify checksums and signatures, run the unit tests, >>> and vote on the release. See [3] for how to validate a release candidate. >>> >>> The vote will be open for at least 72 hours. >>> >>> [ ] +1 Release this as Apache Iceberg Go v0.1.0 >>> [ ] +0 >>> [ ] -1 Do not release this as Apache Iceberg Go v0.1.0 because... >>> >>> Thanks! >>> --Matt >>> >>> [1]: >>> https://github.com/apache/iceberg-go/commit/8ca0bb7bdf7868bac4aca83f50db047d9bf0277c >>> [2]: https://github.com/apache/iceberg-go/releases/v0.1.0-rc1 >>> <https://github.com/apache/iceberg-go/releases/v0.1.0-rc0> >>> [3]: >>> https://github.com/apache/iceberg-go/blob/main/dev/release/README.md#verify >>> >>
