Thanks Ted for the contribution! I agree that this is important to have.
Is there a way to get this work vetted somewhere outside the project to start with, say in a fork or a separate project, and then to incorporate it when users have deployed in production and can provide concrete positive feedback? This is a lot of code to be added at once. I was also wondering how the Python implementation would track changes to the Java implementation. For example, we have since added support for encryption and custom file I/O since this PR was first opened. How would Python take that change? Would every feature added to the Java version need to be mirrored in Python? If so, should the mirroring always happen in-line with the PRs that make the change in Java, or can feature parity be delayed? -Matt Cheah From: Ryan Blue <rb...@netflix.com.INVALID> Reply-To: "dev@iceberg.apache.org" <dev@iceberg.apache.org>, "rb...@netflix.com" <rb...@netflix.com> Date: Thursday, February 28, 2019 at 12:27 PM To: Iceberg Dev List <dev@iceberg.apache.org> Subject: [DISCUSS] Python implementation Hi everyone, One of our contributors, Ted, has done a lot of work on an initial python implementation and Uwe was kind enough to review it. Here's the PR: https://github.com/apache/incubator-iceberg/pull/54 [github.com] Because this is a brand-new implementation, the PR is huge: 157 new files. That makes it really tough to review in depth, and also really time consuming to update and maintain. What I suggest is committing the PR as-is now that it has passed a round of reviews. Then we can improve it in smaller pull requests. Are there any objections to this plan or other thoughts? I think that the python implementation would not be included in the first Apache Iceberg release. I would prefer to release the python implementation on a separate release cycle so that Java blockers don't prevent a Python bug fix and vice versa. rb -- Ryan Blue Software Engineer Netflix
smime.p7s
Description: S/MIME cryptographic signature
