rdblue commented on a change in pull request #7: Allow custom hadoop properties
to be loaded in the Spark data source
URL: https://github.com/apache/incubator-iceberg/pull/7#discussion_r239549558
##########
File path:
spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java
##########
@@ -109,10 +113,18 @@ protected SparkSession lazySparkSession() {
return lazySpark;
}
- protected Configuration lazyConf() {
+ protected Configuration lazyBaseConf() {
if (lazyConf == null) {
this.lazyConf = lazySparkSession().sparkContext().hadoopConfiguration();
}
return lazyConf;
}
+
+ protected Configuration mergeIcebergHadoopConfs(Configuration baseConf,
Map<String, String> options) {
Review comment:
No, this should not be overridden. Probably should be `private static` then.
Creating a new configuration is expensive. As long as the details are
handled in a single class then it is fine to create just one copy and merge
configs into it. It may be more clear that's the behavior if this didn't return
a Configuration and returned void instead, but I think that's minor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
