[
https://issues.apache.org/jira/browse/HIVE-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223745#comment-14223745
]
Szehon Ho commented on HIVE-8955:
---------------------------------
I meant the stats do seem to be updated in
[here|https://github.com/apache/hive/blob/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java#L461]
during the 'alter partition' code path.
Its not checking the flag as you mentioned, but it doesnt look like a bug to
me, as the flag is talking about 'insert overwrite' and not about alter table.
Though my knowledge is more limited as Im not the original author of this
flag/code.
> alter partition should check for "hive.stats.autogather" in hiveConf
> --------------------------------------------------------------------
>
> Key: HIVE-8955
> URL: https://issues.apache.org/jira/browse/HIVE-8955
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Affects Versions: 0.13.1
> Reporter: Pankit Thapar
> Fix For: 0.15.0
>
>
> When alter partition code path is triggered, it should check for the flag
> "hive.stats.autogather", if it is true, then only updateStats else skip them.
> This is done in append_partition code flow.
> Is there any specific reason the alter_partition does not respect this conf
> variable?
> //code snippet : HiveMetastore.java
> private Partition append_partition_common(RawStore ms, String dbName, String
> tableName,
> List<String> part_vals, EnvironmentContext envContext) throws
> InvalidObjectException,
> AlreadyExistsException, MetaException {
> ...
> ....
> if (HiveConf.getBoolVar(hiveConf,
> HiveConf.ConfVars.HIVESTATSAUTOGATHER) &&
> !MetaStoreUtils.isView(tbl)) {
> MetaStoreUtils.updatePartitionStatsFast(part, wh, madeDir);
> }
> ...
> ...
> }
> The above code snippet checks for the variable but this same check is absent
> in
> //code snippet : HiveAlterHandler.java
> public Partition alterPartition(final RawStore msdb, Warehouse wh, final
> String dbname,
> final String name, final List<String> part_vals, final Partition
> new_part)
> throws InvalidOperationException, InvalidObjectException,
> AlreadyExistsException,
> MetaException {
> ....
> ...
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
