[ 
https://issues.apache.org/jira/browse/HIVE-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219583#comment-14219583
 ] 

Brock Noland commented on HIVE-8916:
------------------------------------

Looks like we need to handle the case of null:

{noformat}
2014-11-19 17:39:22,829 WARN  thrift.ThriftCLIService 
(ThriftCLIService.java:OpenSession(242)) - Error opening session: 
java.lang.NullPointerException
        at 
org.apache.hive.service.ServiceUtils.indexOfDomainMatch(ServiceUtils.java:30)
        at 
org.apache.hive.service.cli.thrift.ThriftCLIService.getShortName(ThriftCLIService.java:307)
        at 
org.apache.hive.service.cli.thrift.ThriftCLIService.getUserName(ThriftCLIService.java:300)
        at 
org.apache.hive.service.cli.thrift.ThriftCLIService.getSessionHandle(ThriftCLIService.java:323)
        at 
org.apache.hive.service.cli.thrift.ThriftCLIService.OpenSession(ThriftCLIService.java:236)
        at 
org.apache.hive.service.cli.thrift.ThriftCLIServiceClient.openSession(ThriftCLIServiceClient.java:57)
        at 
org.apache.hive.service.cli.session.TestSessionGlobalInitFile.doTestSessionGlobalInitFile(TestSessionGlobalInitFile.java:126)
        at 
org.apache.hive.service.cli.session.TestSessionGlobalInitFile.testSessionGlobalInitFile(TestSessionGlobalInitFile.java:112)
{noformat}

> Handle user@domain username under LDAP authentication
> -----------------------------------------------------
>
>                 Key: HIVE-8916
>                 URL: https://issues.apache.org/jira/browse/HIVE-8916
>             Project: Hive
>          Issue Type: Bug
>          Components: Authentication
>            Reporter: Mohit Sabharwal
>            Assignee: Mohit Sabharwal
>         Attachments: HIVE-8916.patch
>
>
> If LDAP is configured with multiple domains for authentication, users can be 
> in different domains.
> Currently, LdapAuthenticationProviderImpl blindly appends the domain 
> configured "hive.server2.authentication.ldap.Domain" to the username, which 
> limits user to that domain. However, under multi-domain authentication, the 
> username may already include the domain (ex:  u...@domain.foo.com). We should 
> not append a domain if one is already present.
> Also, if username already includes the domain, rest of Hive and authorization 
> providers still expects the "short name" ("user" and not 
> "u...@domain.foo.com") for looking up privilege rules, etc.  As such, any 
> domain info in the username should be stripped off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to