[ https://issues.apache.org/jira/browse/HIVE-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208364#comment-14208364 ]
Xuefu Zhang commented on HIVE-8793: ----------------------------------- +1. Patch looks good. We don't need a couple of followup JIRAs: 1. Better printing of the work graph. We should print in topological order always. 2. Additional work is needed to make map join work with this change. > Refactor to make splitting SparkWork a physical resolver [Spark Branch] > ----------------------------------------------------------------------- > > Key: HIVE-8793 > URL: https://issues.apache.org/jira/browse/HIVE-8793 > Project: Hive > Issue Type: Sub-task > Components: Spark > Affects Versions: spark-branch > Reporter: Chao > Assignee: Rui Li > Attachments: HIVE-8793.1-spark.patch, HIVE-8793.2-spark.patch > > > Currently, HIVE-8622 is implemented based on an assumption, that for a map > join query, a BaseWork would not have multiple children. By testing through > subquery_multiinsert.q did reveal that's the case. But, we need to > investigate on this, and make sure this won't happen in general. -- This message was sent by Atlassian JIRA (v6.3.4#6332)