----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27720/#review60333 -----------------------------------------------------------
Ship it! Got it. Thanks for the explanation. I'm going to create a separate JIRA requesting to have some tests with stats collection with counter. - Xuefu Zhang On Nov. 7, 2014, 5:27 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27720/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 5:27 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8777 > https://issues.apache.org/jira/browse/HIVE-8777 > > > Repository: hive-git > > > Description > ------- > > Currently we register all hive operator counters in SparkCounters, while > actually not all hive operators are used in SparkTask, we should iterate > SparkTask's operators, and only register conuters required. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java e955da3 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 46b04bc > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/counter/SparkCounters.java > bb3597a > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java 66fd6b6 > > Diff: https://reviews.apache.org/r/27720/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
