> On Nov. 5, 2014, 7:19 p.m., Szehon Ho wrote: > > Let's hold off and see why its picking counter when spark test-driver is > > setup to use "fs", I dont think we can change the qtest to all use fs, as > > different test drivers might want to test with different configurations. > > Hope that makes sense, thanks.
Hi Szehon, I pulled the latest hive-on-spark code and re-generated the .q.out files. This time, I do not need to modify the .q files. Thanks. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27632/#review60001 ----------------------------------------------------------- On Nov. 5, 2014, 6:27 p.m., Na Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27632/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 6:27 p.m.) > > > Review request for hive, Brock Noland, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-7729 > https://issues.apache.org/jira/browse/HIVE-7729 > > > Repository: hive-git > > > Description > ------- > > Enable q-tests for ANALYZE TABLE feature [Spark Branch] > Hive-on-Spark does not support CounterStatsAggregator. Although the default > stats dbclass is fs, but somehow it still uses the counter in the .q tests. I > had to set the hive.stats.dbclass in the .q tests explicitly to be fs. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties c777e45 > ql/src/test/queries/clientpositive/stats0.q 48b5c52 > ql/src/test/queries/clientpositive/stats10.q a3f375e > ql/src/test/queries/clientpositive/stats11.q d037c00 > ql/src/test/queries/clientpositive/stats12.q c1db346 > ql/src/test/queries/clientpositive/stats13.q beb7bfa > ql/src/test/queries/clientpositive/stats14.q 8e74df5 > ql/src/test/queries/clientpositive/stats15.q 7dffa9c > ql/src/test/queries/clientpositive/stats16.q 0557ce6 > ql/src/test/queries/clientpositive/stats18.q e773cd7 > ql/src/test/queries/clientpositive/stats19.q b23b1c3 > ql/src/test/queries/clientpositive/stats2.q d6bb258 > ql/src/test/queries/clientpositive/stats20.q 59701bd > ql/src/test/queries/clientpositive/stats3.q fd7e0ea > ql/src/test/queries/clientpositive/stats5.q 6b5d138 > ql/src/test/queries/clientpositive/stats6.q bef6e88 > ql/src/test/queries/clientpositive/stats7.q 19d0e14 > ql/src/test/queries/clientpositive/stats8.q 46002ca > ql/src/test/queries/clientpositive/stats9.q 48b2044 > ql/src/test/queries/clientpositive/stats_noscan_1.q 02b4c2a > ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30 > ql/src/test/queries/clientpositive/stats_partscan_1.q cdf92e4 > ql/src/test/queries/clientpositive/stats_partscan_1_23.q 905c4c2 > ql/src/test/results/clientpositive/spark/stats0.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats10.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats11.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats12.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats13.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats14.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats15.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats16.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats18.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats19.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats2.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats20.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats3.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats5.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats6.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats7.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats8.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats9.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats_counter.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats_noscan_1.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats_noscan_2.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats_only_null.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/stats_partscan_1_23.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/stats_publisher_error_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/statsfs.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/27632/diff/ > > > Testing > ------- > > > Thanks, > > Na Yang > >
