[
https://issues.apache.org/jira/browse/HIVE-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194986#comment-14194986
]
Ashutosh Chauhan commented on HIVE-5718:
----------------------------------------
Patch doesnt have large amount of changes and looks limited to
{{SimpleFetchOptimizer}} which shouldn't impact majority of Hive production use
cases. However, I agree it has few changes which can be risky at this point in
time. In particular,
* Logic to get to table name and QB in checkTree() looks brittle and make
assumptions about names of subquery blocks. This is susceptible to break with
CBO, which insert artificial names like {{_hdt$0}} for subquery blocks. We need
to look for alternatives here. At the very least, we need to test this with cbo
on and atleast make it defensible to not throw exceptions in those cases.
* In isConvertible() seems like we need to check for more operators like
PTFOperator.
* {code}
- inputs.add(new ReadEntity(table, parent, parent == null));
+ inputs.add(new ReadEntity(table, parent, !table.isView() && parent ==
null));
{code}
This one has security implication. This needs a comment why is this needed.
All of these looks workable to get them sorted out for trunk for sure.
> Support direct fetch for lateral views, sub queries, etc.
> ---------------------------------------------------------
>
> Key: HIVE-5718
> URL: https://issues.apache.org/jira/browse/HIVE-5718
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: D13857.1.patch, D13857.2.patch, D13857.3.patch,
> HIVE-5718.10.patch.txt, HIVE-5718.11.patch.txt, HIVE-5718.12.patch.txt,
> HIVE-5718.13.patch.txt, HIVE-5718.4.patch.txt, HIVE-5718.5.patch.txt,
> HIVE-5718.6.patch.txt, HIVE-5718.7.patch.txt, HIVE-5718.8.patch.txt,
> HIVE-5718.9.patch.txt
>
>
> Extend HIVE-2925 with LV and SubQ.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
