> On Nov. 1, 2014, 12:19 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 3122 > > <https://reviews.apache.org/r/27455/diff/1/?file=746527#file746527line3122> > > > > This will create one less reducer than previous one. I added a fix for > > this is HIVE-8671. Probably you can make similar changes here. I will > > remove those it from HIVE-8671 to avoid conflict.
this is Mostafa's change > On Nov. 1, 2014, 12:19 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java, > > line 173 > > <https://reviews.apache.org/r/27455/diff/1/?file=746529#file746529line173> > > > > This patch will conflict with HIVE-8671. I renamed this method. It will > > make sense to get this patch in first before HIVE-8671. I can resolve conflicts > On Nov. 1, 2014, 12:19 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java, > > line 1437 > > <https://reviews.apache.org/r/27455/diff/1/?file=746529#file746529line1437> > > > > ? will remove - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27455/#review59440 ----------------------------------------------------------- On Oct. 31, 2014, 11:53 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27455/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 11:53 p.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 00a1397 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SetReducerParallelism.java > fef2c29 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > d49eddb > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 1b27c31 > > Diff: https://reviews.apache.org/r/27455/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
