----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27247/#review58833 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkConvertJoinMapJoin.java <https://reviews.apache.org/r/27247/#comment99989> Nit: Let's keep order of the modifies in convention: private static final ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkConvertJoinMapJoin.java <https://reviews.apache.org/r/27247/#comment99992> 1. prviate vs public? 2. some comments on this method would be nice. ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java <https://reviews.apache.org/r/27247/#comment99993> I don't see this method is called anywhere. - Xuefu Zhang On Oct. 27, 2014, 9:53 p.m., Suhas Satish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27247/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 9:53 p.m.) > > > Review request for hive, Rui Li, Szehon Ho, and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > This addresses jira HIVE-8616 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > 46dcfaf > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkConvertJoinMapJoin.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkProcContext.java > ed88c60 > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java > 8e28887 > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java 4f5feca > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java > 1c663c4 > > Diff: https://reviews.apache.org/r/27247/diff/ > > > Testing > ------- > > > Thanks, > > Suhas Satish > >
