> On Oct. 24, 2014, 8:12 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 346 > > <https://reviews.apache.org/r/26721/diff/4/?file=729400#file729400line346> > > > > Can't we use Integer instead of this class?
integer cannot be used as a assignable pass-by-pointer argument, Java doesn't have such concept - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58343 ----------------------------------------------------------- On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26721/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 11:18 p.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java > 0428263 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java > 4f96d02 > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 10ac4b2 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d8c50e3 > ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 > ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION > ql/src/test/results/clientpositive/cbo_correctness.q.out 7c25e1f > ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/cbo_correctness.q.out e467773 > > Diff: https://reviews.apache.org/r/26721/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
