[
https://issues.apache.org/jira/browse/HIVE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183332#comment-14183332
]
Lars Francke commented on HIVE-8583:
------------------------------------
Thanks for taking a look.
The "missorted modifiers" term is coming from my IDE but it is referenced in
the [Java Language
Spec|http://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.3.1]
which lists this order: {{public protected private static final transient
volatile}}. The [Hive Contributors
Guide|https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions]
mentions following the Sun standards so I've set up my IDE to notify me of
these things.
I also think it's great to have consistency in these small details because it
makes foreign code easier to grok. Happy to provide a patch without the change
if you like.
> HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist
> ---------------------------------------------------------------
>
> Key: HIVE-8583
> URL: https://issues.apache.org/jira/browse/HIVE-8583
> Project: Hive
> Issue Type: Improvement
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Attachments: HIVE-8583.1.patch
>
>
> [~alangates] added the following in HIVE-8341:
> {code}
> String bl =
> hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString());
> if (bl != null && bl.length() > 0) {
> String[] bls = bl.split(",");
> for (String b : bls) {
> b.replaceAll(".", "_");
> blackListedConfEntries.add(b);
> }
> }
> {code}
> The {{replaceAll}} call is confusing as its result is not used at all.
> This patch contains the following:
> * Minor style modification (missorted modifiers)
> * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST
> * Removes replaceAll
> * Lets blackListed take a Configuration job as parameter which allowed me to
> add a test for this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
