> On Oct. 21, 2014, 7:37 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1407 > > <https://reviews.apache.org/r/26984/diff/2/?file=727645#file727645line1407> > > > > Thanks, but now I want another change: please make sql all-caps. > > (Picky, picky, picky.)
Looks good, thanks. > On Oct. 21, 2014, 7:37 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 1412-1413 > > <https://reviews.apache.org/r/26984/diff/2/?file=727645#file727645line1412> > > > > Please add a newline, move + to previous line, and init-cap java. Also good, thanks again. - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26984/#review57643 ----------------------------------------------------------- On Oct. 22, 2014, 5:02 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26984/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 5:02 a.m.) > > > Review request for hive, Gunther Hagleitner and Jason Dere. > > > Bugs: HIVE-8534 > https://issues.apache.org/jira/browse/HIVE-8534 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8534 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6a9da7d > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/SettableConfigUpdater.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > 658ff76 > > ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/TestSQLStdHiveAccessControllerHS2.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerHS2.java > f13cf7e > ql/src/test/queries/clientnegative/authorization_disallow_transform.q > 342c29a > ql/src/test/results/clientnegative/authorization_disallow_transform.q.out > 39819b6 > > Diff: https://reviews.apache.org/r/26984/diff/ > > > Testing > ------- > > Tests updated > > > Thanks, > > Thejas Nair > >
