> On Oct. 16, 2014, 7:32 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 3265 > > <https://reviews.apache.org/r/26481/diff/1/?file=716405#file716405line3265> > > > > there's a flag for enabling dynamic partitioning. is this checked > > somewhere in this path? ppl use that to avoid someone accidentally changing > > everything.
Good point, will add that check. > On Oct. 16, 2014, 7:32 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 3269 > > <https://reviews.apache.org/r/26481/diff/1/?file=716405#file716405line3269> > > > > why does this fail? it seems more consistent to just alter 0 partitions > > in this case. or at least just print a warning instead of failing. This is just the existing behavior right? This is if the user specifies a non-existent partition, including if they specify all partition values in the spec, like (part1='nonexistent', part2='partition'). I think this is sensible behavior, but reply if you think otherwise. We could just fail in the event that the partition spec specifies values for all of the partition columns, if you think that is better. > On Oct. 16, 2014, 7:32 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 3301 > > <https://reviews.apache.org/r/26481/diff/1/?file=716405#file716405line3301> > > > > LOG.error? Whoops, will fix. > On Oct. 16, 2014, 7:32 a.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 60 > > <https://reviews.apache.org/r/26481/diff/1/?file=716407#file716407line60> > > > > does this support multi level partitioning? if so can you specify only > > some of the partitions? You mean like multiple partition columns? I'll change the test to include that. > On Oct. 16, 2014, 7:32 a.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 63 > > <https://reviews.apache.org/r/26481/diff/1/?file=716407#file716407line63> > > > > add a query to verify the output? Will fix. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26481/#review56905 ----------------------------------------------------------- On Oct. 9, 2014, 3:14 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26481/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 3:14 a.m.) > > > Review request for hive, Gunther Hagleitner and Thejas Nair. > > > Bugs: HIVE-8411 > https://issues.apache.org/jira/browse/HIVE-8411 > > > Repository: hive-git > > > Description > ------- > > Allow partial partition spec for some alter table statements, such as: > > alter table alter_partition_change_col1 partition (p1) change column c2 c2 > decimal(10,0); > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d5374bc > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 4e58ad8 > ql/src/test/queries/clientpositive/alter_partition_change_col.q baabb9f > ql/src/test/results/clientpositive/alter_partition_change_col.q.out 7123e40 > > Diff: https://reviews.apache.org/r/26481/diff/ > > > Testing > ------- > > updated qfile test > > > Thanks, > > Jason Dere > >
