----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26569/#review56288 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java <https://reviews.apache.org/r/26569/#comment96587> Nit: need a space between the arguments. ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTran.java <https://reviews.apache.org/r/26569/#comment96588> Nit: could we group the params as <KI,VI,KO,VO> instead, which seems more natural? - Xuefu Zhang On Oct. 11, 2014, 12:31 a.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26569/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2014, 12:31 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8276 > https://issues.apache.org/jira/browse/HIVE-8276 > > > Repository: hive-git > > > Description > ------- > > Currently ShuffleTran captures both shuffle and reduce side processing. Per > HIVE-8118, sometimes the output RDD from shuffle needs to be cached for > better performance. Thus, it makes sense to separate shuffle from Reduce and > create ShuffleTran class. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/IdentityTran.java 6c3cf2f > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java 0732e06 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapTran.java e62527c > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ReduceTran.java 52ac724 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java > 8e251df > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTran.java e770158 > > Diff: https://reviews.apache.org/r/26569/diff/ > > > Testing > ------- > > > Thanks, > > Chao Sun > >
