> On Oct. 2, 2014, 10:08 p.m., Alan Gates wrote: > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1322 > > <https://reviews.apache.org/r/25682/diff/2/?file=710033#file710033line1322> > > > > Rather than saying "to turn on Hive transactions" this should read "as > > part of turning on Hive transactions". This change alone won't turn on > > transactions. > > Lefty Leverenz wrote: > Agreed. How about hive.txn.manager? ("To turn on Hive transactions, set > to org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.") Should all 3 parameters > list the others that are required? Oh ... make that 4 parameters, including > hive.support.concurrency. > > For example: "Set this to true on one instance of the Thrift metastore > service as part of turning on Hive transactions. The parameters > hive.txn.manager, hive.compactor.worker.threads, and hive.support.concurrency > must also be set appropriately to turn on Hive transactions." > > Alan Gates wrote: > I don't know how verbose you want to get in HiveConf.java. It might make > sense to detail all the required parameters under hive.txn.manager and then > have pointers to it from the compactor ones. I don't think you need pointers > from hive.support.concurrency since that has other uses beyond just turning > on transactions.
Good solution -- easy to maintain. Thanks. - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25682/#review55256 ----------------------------------------------------------- On Oct. 1, 2014, 7:27 a.m., Lefty Leverenz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25682/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 7:27 a.m.) > > > Review request for hive, Carl Steinbach, Alan Gates, Navis Ryu, Prasad > Mujumdar, and Sergey Shelukhin. > > > Bugs: HIVE-6586 > https://issues.apache.org/jira/browse/HIVE-6586 > > > Repository: hive > > > Description > ------- > > HIVE-6586 kept track of new configuration parameters and changes to parameter > descriptions when HIVE-6037 moved parameter descriptions into HiveConf.java > from hive-default.xml.template. > > HIVE-6586.patch addresses all the fixes listed in the JIRA comments (except > ones that had already been fixed), tidies up some line breaks, and makes > minor edits to parameter descriptions. It also revises the descriptions of > hive.txn.xxx, hive.compactor.xxx, hive.server2.async.exec.shutdown.timeout, > and hive.security.authorization.createtable.owner.grants. > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1628586 > > Diff: https://reviews.apache.org/r/25682/diff/ > > > Testing > ------- > > Generated hive-default.xml.template (attached to HIVE-6586) from the new > HiveConf.java and reviewed the changed parameter descriptions. > > > File Attachments > ---------------- > > Patch 2, rebased and fixed some issues > > https://reviews.apache.org/media/uploaded/files/2014/10/01/8e4b539e-2590-4d8e-b3b5-45175a051f9d__HIVE-6586.2.patch > > > Thanks, > > Lefty Leverenz > >
