[
https://issues.apache.org/jira/browse/HIVE-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146233#comment-14146233
]
Hive QA commented on HIVE-8111:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12670862/HIVE-8111.02.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6343 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_udf
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_tez_union_group_by
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/960/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/960/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-960/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12670862
> CBO trunk merge: duplicated casts for arithmetic expressions in Hive and CBO
> ----------------------------------------------------------------------------
>
> Key: HIVE-8111
> URL: https://issues.apache.org/jira/browse/HIVE-8111
> Project: Hive
> Issue Type: Sub-task
> Components: CBO
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-8111.01.patch, HIVE-8111.02.patch, HIVE-8111.patch
>
>
> Original test failure: looks like column type changes to different decimals
> in most cases. In one case it causes the integer part to be too big to fit,
> so the result becomes null it seems.
> What happens is that CBO adds casts to arithmetic expressions to make them
> type compatible; these casts become part of new AST, and then Hive adds casts
> on top of these casts. This (the first part) also causes lots of out file
> changes. It's not clear how to best fix it so far, in addition to incorrect
> decimal width and sometimes nulls when width is larger than allowed in Hive.
> Option one - don't add those for numeric ops - cannot be done if numeric op
> is a part of compare, for which CBO needs correct types.
> Option two - unwrap casts when determining type in Hive - hard or impossible
> to tell apart CBO-added casts and user casts.
> Option three - don't change types in Hive if CBO has run - seems hacky and
> hard to ensure it's applied everywhere.
> Option four - map all expressions precisely between two trees and remove
> casts again after optimization, will be pretty difficult.
> Option five - somehow mark those casts. Not sure about how yet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
