[ 
https://issues.apache.org/jira/browse/HIVE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145674#comment-14145674
 ] 

Alan Gates commented on HIVE-8164:
----------------------------------

Since the classes in this patch are really for use outside of Hive by third 
party system such as Falcon, it makes sense to note that in the 
package-info.java file and give some info on how a tool might use those files.

ReplicationTask.needsStagingDir - It would make more sense for this to be 
abstract and let each subtype say yes/no rather than encoding the logic for 
each subtype here.

ReplicationTask.getSrcWhCommands and getDstWhCommands should be abstract as 
well.

At least one real implementation of ReplicationTask would make it easier to 
determine whether this is the right interface or not.



> Adding in a ReplicationTask that converts a Notification Event to actionable 
> tasks
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-8164
>                 URL: https://issues.apache.org/jira/browse/HIVE-8164
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Import/Export
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-8164.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to