[ 
https://issues.apache.org/jira/browse/HIVE-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144600#comment-14144600
 ] 

Damien Carol commented on HIVE-7689:
------------------------------------

{quote}
If postgres requires lower case table and column names I'd prefer to change the 
postgres version of hive-txn-schema.sql to create the tables and columns with 
lower case names.
{quote}
We can't. All tables in current metastore scripts are uppercase in postgres. 
Breaking this convention will be painful.
{quote}
All these calls to getEscape make the code hard to read.
{quote}
There are 3 solutions to this pb.
1. Rewrite this patch to use Datanucleus where it's possible (not in stats 
part). => HARD and very intrusive
2. Use thrid party library to generate SQL (think about JOOQ 
http://www.jooq.org/ ASF license) => easy and well designed BUT add another lib 
dependency
3. Keep minimum modifications, use a simple solution to add Identifier Escape 
=> it's the way the patch follows, adding a function to get Identifier Escape 
char from connector

Tell me: if you want, I rewrite the patch but, as is, postgres cannot be used.

> Enable Postgres as METASTORE back-end
> -------------------------------------
>
>                 Key: HIVE-7689
>                 URL: https://issues.apache.org/jira/browse/HIVE-7689
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.14.0
>            Reporter: Damien Carol
>            Assignee: Damien Carol
>            Priority: Minor
>              Labels: metastore, postgres
>             Fix For: 0.14.0
>
>         Attachments: HIVE-7689.5.patch, HIVE-7689.6.patch, HIVE-7689.7.patch, 
> HIVE-7689.8.patch, HIVE-7889.1.patch, HIVE-7889.2.patch, HIVE-7889.3.patch, 
> HIVE-7889.4.patch
>
>
> I maintain few patches to make Metastore works with Postgres back end in our 
> production environment.
> The main goal of this JIRA is to push upstream these patches.
> This patch enable LOCKS, COMPACTION and fix error in STATS on postgres 
> metastore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to