> On Sept. 16, 2014, 4:18 a.m., cheng xu wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestColumnAccess.java, line 1 > > <https://reviews.apache.org/r/25329/diff/2/?file=689279#file689279line1> > > > > Just a suggestion, you can use query test instead of unit test to avoid > > some many assert statements.
Thx Cheng, I just want to test SemanticAnalyzer in compile, no run in my test cases. So there is no output in my test cases. I think query tests are not match my requirement. - Xiaomeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25329/#review53462 ----------------------------------------------------------- On Sept. 15, 2014, 11:29 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25329/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 11:29 a.m.) > > > Review request for hive, Brock Noland, Prasad Mujumdar, and Szehon Ho. > > > Repository: hive-git > > > Description > ------- > > When I execute a query with view join, the view's type is table, but > tableToColumnAccessMap will not store view's name, so it will throw null > pointer exception > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 392f7ce > ql/src/test/org/apache/hadoop/hive/ql/parse/TestColumnAccess.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25329/diff/ > > > Testing > ------- > > > Thanks, > > Xiaomeng Huang > >
