> On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 3255 > > <https://reviews.apache.org/r/25320/diff/1/?file=676162#file676162line3255> > > > > small recommendation: every branch in this seems to have the same > > if/else wrt fetching stuff from tbl or part. can we pull out cols, serlib, > > sd once at the beginning and have the rest of this just use it? slightly > > cleaner and less error prone.
Will see what I can do here. > On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java, line > > 274 > > <https://reviews.apache.org/r/25320/diff/1/?file=676163#file676163line274> > > > > what about other cases? location, serde, etc? File format/location are already supported per partition per https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AlterEitherTableorPartition > On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 11 > > <https://reviews.apache.org/r/25320/diff/1/?file=676166#file676166line11> > > > > it'd be more interesting to see the full table output. where one part > > is 10,0 and one is 14,4 will do > On Sept. 12, 2014, 6:58 p.m., Gunther Hagleitner wrote: > > ql/src/test/queries/clientpositive/alter_partition_change_col.q, line 19 > > <https://reviews.apache.org/r/25320/diff/1/?file=676166#file676166line19> > > > > before changing the table too, you should try just removing it on the > > partition, that should yield a null in the dec col. will change - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25320/#review53197 ----------------------------------------------------------- On Sept. 3, 2014, 11:57 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25320/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 11:57 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-7971 > https://issues.apache.org/jira/browse/HIVE-7971 > > > Repository: hive-git > > > Description > ------- > > Allow change/replace/add column to work on partitions > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java e42bbdd > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 05cde3e > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 25cd3a5 > ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 8517319 > ql/src/test/queries/clientpositive/alter_partition_change_col.q > PRE-CREATION > ql/src/test/results/clientpositive/alter_partition_change_col.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/25320/diff/ > > > Testing > ------- > > New qfile test added > > > Thanks, > > Jason Dere > >
