-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25595/
-----------------------------------------------------------

Review request for hive and Brock Noland.


Bugs: HIVE-8083
    https://issues.apache.org/jira/browse/HIVE-8083


Repository: hive-git


Description
-------

The compiler expects principals (user, group and role) as hive identifiers for 
authorization DDLs. The user and group are entities that belong to external 
namespace and we can't expect those to follow hive identifier syntax rules. For 
example, a userid or group can contain '-' which is not allowed by compiler.
The patch is to allow string literal for user and group names.
The quoted identifier support perhaps can be made to work with this. However 
IMO this syntax should be supported regardless of quoted identifier support 
(which is an optional configuration)


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 25cd3a5 
  ql/src/test/queries/clientpositive/authorization_non_id.q PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_non_id.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/25595/diff/


Testing
-------

Added test case to verify various auth DDLs with new syntax.


Thanks,

Prasad Mujumdar

Reply via email to