----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245/#review53097 -----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/25245/#comment92500> I read some more about zookeeper ACL. Looks like just this READ_ACL_UNSAFE will not allow the hive user to delete the entry. It seems like we need to combine CREATOR_ALL_ACL and READ_ACL_UNSAFE and pass on to these functions. But looking at CREATOR_ALL_ACL code in zookeeper and the definition of "auth" scheme, it seems like it considers any authenticated user as owner, not just the current user. We need to clarify this with some zookeeper export. - Thejas Nair On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25245/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 1:08 p.m.) > > > Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair. > > > Bugs: HIVE-7935 > https://issues.apache.org/jira/browse/HIVE-7935 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7935 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5d2e6b0 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > ae128a9 > jdbc/pom.xml 1ad13a7 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java 6e248d6 > jdbc/src/java/org/apache/hive/jdbc/JdbcUriParseException.java PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/Utils.java 58339bf > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientException.java > PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 0919d2f > ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java > 59294b1 > service/src/java/org/apache/hive/service/cli/CLIService.java a0bc905 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > f5a8f27 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > b0bb8be > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 11d25cc > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 2b80adc > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 443c371 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > 4067106 > service/src/java/org/apache/hive/service/server/HiveServer2.java 124996c > > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java > 66fc1fc > > Diff: https://reviews.apache.org/r/25245/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Vaibhav Gumashta > >
