[ 
https://issues.apache.org/jira/browse/HIVE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128249#comment-14128249
 ] 

Rui Li commented on HIVE-8035:
------------------------------

I also have one concern that some qfile contains both cases with and without a 
guaranteed order. For example in {{limit_pushdown.q}}, we have both:
{{select key,value from src order by key desc limit 20;}}
and
{{select value, sum(key + 1) as sum from src group by value limit 20;}}

If we add {{-- SORT_QUERY_RESULTS}}, the generated results can be different 
from the expected, e.g. for an {{order by desc}} query.
Do you think this is OK?

> Add SORT_QUERY_RESULTS for test that doesn't guarantee order
> ------------------------------------------------------------
>
>                 Key: HIVE-8035
>                 URL: https://issues.apache.org/jira/browse/HIVE-8035
>             Project: Hive
>          Issue Type: Test
>          Components: Tests
>            Reporter: Rui Li
>            Assignee: Rui Li
>            Priority: Minor
>         Attachments: HIVE-8035.patch
>
>
> Some test query doesn't guarantee output order, e.g. group by, union all. 
> Therefore we should add {{-- SORT_QUERY_RESULTS}} to the qfiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to