> On Sept. 9, 2014, 10:55 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 3454 > > <https://reviews.apache.org/r/25460/diff/1-2/?file=682938#file682938line3454> > > > > this should not be throwing any exception. I assume the code here does > > not, so the 'throws IOException' can be removed. > > If it were to throw an exception then that exception would mask the > > exception from mkdirs.
Ah sorry, missed that. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25460/#review52795 ----------------------------------------------------------- On Sept. 9, 2014, 11:06 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25460/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 11:06 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8022 > https://issues.apache.org/jira/browse/HIVE-8022 > > > Repository: hive-git > > > Description > ------- > > Recursive root scratch directory creation is not using hdfs umask properly > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 5dce16f > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bbf3f6 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f149a > > Diff: https://reviews.apache.org/r/25460/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
