----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25395/#review52492 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java <https://reviews.apache.org/r/25395/#comment91291> Remove the comment // map side no grouping set ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java <https://reviews.apache.org/r/25395/#comment91292> Ideally we should be taking into account the NDV of the group by columns and not divide by 2. - Mostafa Mokhtar On Sept. 5, 2014, 6:58 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25395/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 6:58 p.m.) > > > Review request for hive, Ashutosh Chauhan, Gunther Hagleitner, and Harish > Butani. > > > Bugs: HIVE-7990 > https://issues.apache.org/jira/browse/HIVE-7990 > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > 01c1d30 > ql/src/test/queries/clientpositive/annotate_stats_groupby.q e8e84c6 > ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 9c37d9b > ql/src/test/results/clientpositive/groupby_cube1.q.out 4246744 > ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 1cd65f6 > ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out f1ecbb4 > ql/src/test/results/clientpositive/groupby_rollup1.q.out 5db5cd5 > > Diff: https://reviews.apache.org/r/25395/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
