----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245/#review52139 -----------------------------------------------------------
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/25245/#comment90887> How big are the zookeeper jars ? If we use zookeeper in this class, I believe zookeeper jars will always be needed for jdbc driver. It would be better to have the zookeeper service discovery code in a separate util class. That way we will need zookeeper jars only if this mode is used. service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/25245/#comment90889> It will be useful to log at info level that it is re-using the existing znode. service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/25245/#comment90890> It will be useful to have HS2 de-register itself if it gets a kill signal it can handle. That part can be done as part of follow-up jira as well. (Until then admin will need to manually edit the zookeeper entry). - Thejas Nair On Sept. 2, 2014, 10:05 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25245/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 10:05 a.m.) > > > Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair. > > > Bugs: HIVE-7935 > https://issues.apache.org/jira/browse/HIVE-7935 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7935 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 46044d0 > ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java > 59294b1 > service/src/java/org/apache/hive/service/cli/CLIService.java 08ed2e7 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 21c33bc > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > bc0a02c > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > d573592 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 37b05fc > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 027931e > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > c380b69 > service/src/java/org/apache/hive/service/server/HiveServer2.java 0864dfb > > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java > 66fc1fc > > Diff: https://reviews.apache.org/r/25245/diff/ > > > Testing > ------- > > Manual testing + test cases. > > > Thanks, > > Vaibhav Gumashta > >
