[ https://issues.apache.org/jira/browse/HIVE-7921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116224#comment-14116224 ]
Hive QA commented on HIVE-7921: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12665527/HIVE-7921.1.patch {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 6132 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8 org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/572/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/572/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-572/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12665527 > Fix confusing dead assignment in return statement > (JavaHiveVarcharObjectInspector) > ---------------------------------------------------------------------------------- > > Key: HIVE-7921 > URL: https://issues.apache.org/jira/browse/HIVE-7921 > Project: Hive > Issue Type: Improvement > Reporter: Lars Francke > Assignee: Lars Francke > Priority: Minor > Attachments: HIVE-7921.1.patch > > > There are multiple instances of something like this {{return o = new > HiveVarchar(value, getMaxLength());}} in this class. That's not only > confusing but also useless as it doesn't do anything. > I've removed those assignments and cleaned up the class a bit. -- This message was sent by Atlassian JIRA (v6.2#6252)