----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ -----------------------------------------------------------
(Updated Aug. 29, 2014, 8:59 p.m.) Review request for hive, Brock Noland, Szehon Ho, and Xuefu Zhang. Changes ------- 1. removed the new union_remove_spark q and q.out files 2. added hive.merge.sparkfiles config properties to all union_remove_*.q files Bugs: HIVE-7870 https://issues.apache.org/jira/browse/HIVE-7870 Repository: hive-git Description ------- HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch] The cause of this problem is during spark/tez task generation, the union file sink operator are cloned to two new filesink operator. The linkedfilesinkdesc info for those new filesink operators are missing. In addition, the two new filesink operators also need to be linked together. Diffs (updated) ----- itests/src/test/resources/testconfiguration.properties 88ef4f8 ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 9c808d4 ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkProcContext.java 5ddc16d ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 379a39c ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 76fc290 ql/src/test/queries/clientpositive/union_remove_1.q c87b3fe ql/src/test/queries/clientpositive/union_remove_10.q 6701952 ql/src/test/queries/clientpositive/union_remove_11.q 4b2fa42 ql/src/test/queries/clientpositive/union_remove_12.q 69d0d0a ql/src/test/queries/clientpositive/union_remove_13.q 7605f0e ql/src/test/queries/clientpositive/union_remove_14.q a4fdfc8 ql/src/test/queries/clientpositive/union_remove_15.q e3c937b ql/src/test/queries/clientpositive/union_remove_16.q 537078b ql/src/test/queries/clientpositive/union_remove_17.q d70f3d3 ql/src/test/queries/clientpositive/union_remove_18.q 6352bc3 ql/src/test/queries/clientpositive/union_remove_19.q 8c45953 ql/src/test/queries/clientpositive/union_remove_2.q 83cd288 ql/src/test/queries/clientpositive/union_remove_20.q f80f7c1 ql/src/test/queries/clientpositive/union_remove_21.q 8963c25 ql/src/test/queries/clientpositive/union_remove_22.q b0c1ccd ql/src/test/queries/clientpositive/union_remove_23.q a1b989a ql/src/test/queries/clientpositive/union_remove_24.q ec561e0 ql/src/test/queries/clientpositive/union_remove_25.q 76c1ff5 ql/src/test/queries/clientpositive/union_remove_3.q 9617f73 ql/src/test/queries/clientpositive/union_remove_4.q cae323b ql/src/test/queries/clientpositive/union_remove_5.q 5df84e1 ql/src/test/queries/clientpositive/union_remove_6.q bfce26d ql/src/test/queries/clientpositive/union_remove_7.q 3a95674 ql/src/test/queries/clientpositive/union_remove_8.q a83a43e ql/src/test/queries/clientpositive/union_remove_9.q e71f6dd ql/src/test/results/clientpositive/spark/union10.q.out 20c681e ql/src/test/results/clientpositive/spark/union18.q.out 3f37a0a ql/src/test/results/clientpositive/spark/union19.q.out 6922fcd ql/src/test/results/clientpositive/spark/union28.q.out 8bd5218 ql/src/test/results/clientpositive/spark/union29.q.out b9546ef ql/src/test/results/clientpositive/spark/union3.q.out 3ae6536 ql/src/test/results/clientpositive/spark/union30.q.out 12717a1 ql/src/test/results/clientpositive/spark/union33.q.out b89757f ql/src/test/results/clientpositive/spark/union4.q.out 6341cd9 ql/src/test/results/clientpositive/spark/union6.q.out 263d9f4 ql/src/test/results/clientpositive/spark/union_remove_10.q.out 927a15d ql/src/test/results/clientpositive/spark/union_remove_11.q.out 96651e1 ql/src/test/results/clientpositive/spark/union_remove_16.q.out 0954ae4 ql/src/test/results/clientpositive/spark/union_remove_4.q.out cc46dda ql/src/test/results/clientpositive/spark/union_remove_5.q.out f6cdeb3 ql/src/test/results/clientpositive/spark/union_remove_9.q.out 1f0260c Diff: https://reviews.apache.org/r/25176/diff/ Testing ------- Thanks, Na Yang