[ 
https://issues.apache.org/jira/browse/HIVE-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114100#comment-14114100
 ] 

Prasanth J commented on HIVE-7896:
----------------------------------

Pretty useful patch! I took a quick look at the patch. Mostly looks good. 
Couple of comments
1) The arg name for rowindex is actually misleading "comma separated list of 
row indices". It is not CSV of row indices but CSV of column ids for which row 
index should be printed. We should either rename the arg or arg name.
2) I tried printing data for the attached ORC file. It fails with the following 
exception
{code}
Exception in thread "main" org.codehaus.jettison.json.JSONException: Value out 
of sequence.
        at org.codehaus.jettison.json.JSONWriter.append(JSONWriter.java:136)
        at org.codehaus.jettison.json.JSONWriter.value(JSONWriter.java:323)
        at org.apache.hadoop.hive.ql.io.orc.FileDump.printMap(FileDump.java:250)
        at 
org.apache.hadoop.hive.ql.io.orc.FileDump.printObject(FileDump.java:311)
        at 
org.apache.hadoop.hive.ql.io.orc.FileDump.printStruct(FileDump.java:287)
        at 
org.apache.hadoop.hive.ql.io.orc.FileDump.printObject(FileDump.java:302)
        at 
org.apache.hadoop.hive.ql.io.orc.FileDump.printJsonData(FileDump.java:352)
        at org.apache.hadoop.hive.ql.io.orc.FileDump.printData(FileDump.java:88)
        at org.apache.hadoop.hive.ql.io.orc.FileDump.main(FileDump.java:81)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.apache.hadoop.util.RunJar.main(RunJar.java:160)
{code}
I am attaching the ORC file and corresponding text file for reference.

> orcfiledump should be able to dump data
> ---------------------------------------
>
>                 Key: HIVE-7896
>                 URL: https://issues.apache.org/jira/browse/HIVE-7896
>             Project: Hive
>          Issue Type: Improvement
>          Components: File Formats
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-7896.patch
>
>
> The FileDumper utility in orc, exposed as a service as orcfiledump, can print 
> out metadata from Orc files but not the actual data.  Being able to dump the 
> data is also useful in some debugging contexts.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to