> On Aug. 26, 2014, 6:04 p.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 9537 > > <https://reviews.apache.org/r/24962/diff/4/?file=668713#file668713line9537> > > > > Can you please remove this as per our previous discussion? The > > construction of new linkedlist is not needed.
fixed > On Aug. 26, 2014, 6:04 p.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 9540 > > <https://reviews.apache.org/r/24962/diff/4/?file=668713#file668713line9540> > > > > Please indent 2 spaces instead of 4. fixed > On Aug. 26, 2014, 6:04 p.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 9544 > > <https://reviews.apache.org/r/24962/diff/4/?file=668713#file668713line9544> > > > > Please indent 2 spaces. fixed - Xiaomeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24962/#review51554 ----------------------------------------------------------- On Aug. 26, 2014, 2:22 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24962/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 2:22 a.m.) > > > Review request for hive, Prasad Mujumdar and Szehon Ho. > > > Repository: hive-git > > > Description > ------- > > External authorization model can not get accessed columns from query. Hive > should store accessed columns to ReadEntity > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 7ed50b4 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b05d3b4 > > Diff: https://reviews.apache.org/r/24962/diff/ > > > Testing > ------- > > > Thanks, > > Xiaomeng Huang > >
