----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24920/ -----------------------------------------------------------
Review request for hive and John Pullokkaran. Repository: hive Description ------- CBO path doesn't handle null expr in select list correctly. Diffs ----- branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTBuilder.java 1619293 branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java 1619294 branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/RexNodeConverter.java 1619293 branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/TypeConverter.java 1619293 branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1619294 branches/cbo/ql/src/test/queries/clientpositive/cbo_correctness.q 1619294 branches/cbo/ql/src/test/results/clientpositive/cbo_correctness.q.out 1619294 Diff: https://reviews.apache.org/r/24920/diff/ Testing ------- added new test. Thanks, Ashutosh Chauhan