[
https://issues.apache.org/jira/browse/HIVE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104484#comment-14104484
]
David Chen commented on HIVE-7420:
----------------------------------
Thanks for your review, [~cwsteinbach]. I have addressed the major points you
listed above and made the following changes:
* The test failures in TestHCatLoader, HCatLoaderComplexSchema, HCatStorer,
and HCatStorerMulti were caused by the tests running against Avro after
HIVE-6806 was committed. I have fixed those failures by disabling running the
tests against Avro.
* I have added a utility class to take a storage format and a
Map<storage_format, List<disabled_test_methods>> and determine whether the
caller test method should be skipped and updated the above four test suites
accordingly so that individual test methods can be skipped.
* I looked into JUnitParams; however, I found that it does not have a good way
of passing the parameter to a Before method. Since there are a couple of test
suites that need the parameter in a Before method, I do not think this
particular library is very suitable. It may be possible to extend the JUnit
Parameters class or write a custom JUnit Runner. It would be nice to have JUnit
print the parameters, but let's do this in a separate ticket.
I have uploaded a new patch for pre-commit testing. I will upload another patch
after addressing the remaining RB comments.
> Parameterize tests for HCatalog Pig interfaces for testing against all
> storage formats
> --------------------------------------------------------------------------------------
>
> Key: HIVE-7420
> URL: https://issues.apache.org/jira/browse/HIVE-7420
> Project: Hive
> Issue Type: Sub-task
> Components: HCatalog
> Reporter: David Chen
> Assignee: David Chen
> Attachments: HIVE-7420-without-HIVE-7457.2.patch,
> HIVE-7420-without-HIVE-7457.3.patch, HIVE-7420-without-HIVE-7457.4.patch,
> HIVE-7420.1.patch, HIVE-7420.2.patch, HIVE-7420.3.patch, HIVE-7420.4.patch
>
>
> Currently, HCatalog tests only test against RCFile with a few testing against
> ORC. The tests should be covering other Hive storage formats as well.
> HIVE-7286 turns HCatMapReduceTest into a test fixture that can be run with
> all Hive storage formats and with that patch, all test suites built on
> HCatMapReduceTest are running and passing against Sequence File, Text, and
> ORC in addition to RCFile.
> Similar changes should be made to make the tests for HCatLoader and
> HCatStorer generic so that they can be run against all Hive storage formats.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
