----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23797/#review50848 -----------------------------------------------------------
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java <https://reviews.apache.org/r/23797/#comment88721> According to the JUnit docs a "failing assumption in a @Before or @BeforeClass method will have the same effect as a failing assumption in each @Test method of the class." I think it's better to explicitly add this to each test method. hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java <https://reviews.apache.org/r/23797/#comment88719> Do all of these tests fail for Parquet format or only a subset of them? hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java <https://reviews.apache.org/r/23797/#comment88720> Is it possible to static import this (e.g. like assertTrue)? ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java <https://reviews.apache.org/r/23797/#comment88716> The javadoc doesn't agree with the actual return type of this method. People who aren't familiar with JUnit and/or aren't aquainted with the requirements of the Parameterized API aren't going to understand why this method doesn't return List<String>. Can you please add a note explaining this and also consider changing the name of the method in order to reduce the chance of confusion? - Carl Steinbach On July 31, 2014, 1:38 a.m., David Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23797/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 1:38 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7420 > https://issues.apache.org/jira/browse/HIVE-7420 > > > Repository: hive-git > > > Description > ------- > > HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against > all storage formats. > > > HIVE-7457: Minor HCatalog Pig Adapter test clean up. > > > Diffs > ----- > > hcatalog/hcatalog-pig-adapter/pom.xml > 4d2ca519d413b7de0a6a8b50f9a099c3539fc432 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/MockLoader.java > c87b95a00af03d2531eb8bbdda4e307c3aac1fe2 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java > a4b55c8463b3563f1e602ae2d0809dd318bcfa7f > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java > 82fc8a9391667138780be8796931793661f61ebb > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java > eadbf20afc525dd9f33e9e7fb2a5d5cb89907d7e > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java > fcfc6428e7db80b8bfe0ce10e37d7b0ee6e58e20 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java > 76080f7635548ed9af114c823180d8da9ea8f6c2 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerWrapper.java > 7f0bca763eb07db3822c6d6028357e81278803c9 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java > 82eb0d72b4f885184c094113f775415c06bdce98 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoaderComplexSchema.java > 05387711289279cab743f51aee791069609b904a > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatPigStorer.java > a9b452101c15fb7a3f0d8d0339f7d0ad97383441 > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java > 1084092828a9ac5e37f5b50b9c6bbd03f70b48fd > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java > a8ce61aaad42b03e4de346530d0724f3d69776b9 > ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java > 19fdeb5ed3dba7a3bcba71fb285d92d3f6aabea9 > > Diff: https://reviews.apache.org/r/23797/diff/ > > > Testing > ------- > > > Thanks, > > David Chen > >
