> On Aug. 17, 2014, 9:04 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java, line 244 > > <https://reviews.apache.org/r/24762/diff/1/?file=661974#file661974line244> > > > > Should we use Guava splitter here? > > > > private static final Splitter CSV_SPLITTER = > > Splliter.on(",").omitEmpty(); > > > > then we can: > > > > for x in CSV_SPLITTER.split(Strings.nulltoEmpty(x)) > > > > without any additional checks?
Thanks Brock. Yep, it makes to use Guava spitter here. Changed in new patch. - Venki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24762/#review50845 ----------------------------------------------------------- On Aug. 16, 2014, 1:36 a.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24762/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 1:36 a.m.) > > > Review request for hive, Brock Noland and Szehon Ho. > > > Bugs: HIVE-7746 > https://issues.apache.org/jira/browse/HIVE-7746 > > > Repository: hive-git > > > Description > ------- > > Minor cleanup and thread safe refreshLocalResource needed for HIVE-7606. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkClient.java bfb34ec > > Diff: https://reviews.apache.org/r/24762/diff/ > > > Testing > ------- > > > Thanks, > > Venki Korukanti > >
