[
https://issues.apache.org/jira/browse/HIVE-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099279#comment-14099279
]
Alan Gates commented on HIVE-7513:
----------------------------------
This patch is almost ready. I have a couple of comments (see below) but they
aren't blockers to getting this checked in. Things we do need to address
before checkin:
* Need blessing from Owen or Prasanth (both of whom understand ORC better than
me) that the changes to OrcInputFormat are ok.
* Latest test results from the build bot
Comments:
* The instanceof calls in the middle of HiveContextAwareRecordReader.next look
ugly, since this is in the inner record fetching loop. But I can't think of a
better way to do it. Subclassing for this would be hard since it would force
subclassing of each of the existing subclasses of HiveContextAwareRecordReader.
The performance penalty for this should not be bad as for any given query the
same path will be chosen for all records, thus branch prediction should perform
quite well. We shouldn't hold up the check in for this, but we should think on
how to improve this later.
* In FetchOperator a few includes were made unnecessary but not removed from
the file. I'll remove them when I check the code in. I'm only noting it here
for the record so it's clear why the file I check in differs slightly from the
patch provided.
> Add ROW__ID VirtualColumn
> -------------------------
>
> Key: HIVE-7513
> URL: https://issues.apache.org/jira/browse/HIVE-7513
> Project: Hive
> Issue Type: Sub-task
> Components: Query Processor
> Affects Versions: 0.13.1
> Reporter: Eugene Koifman
> Assignee: Eugene Koifman
> Attachments: HIVE-7513.10.patch, HIVE-7513.11.patch,
> HIVE-7513.12.patch, HIVE-7513.3.patch, HIVE-7513.4.patch, HIVE-7513.5.patch,
> HIVE-7513.8.patch, HIVE-7513.9.patch, HIVE-7513.codeOnly.txt
>
>
> In order to support Update/Delete we need to read rowId from AcidInputFormat
> and pass that along through the operator pipeline (built from the WHERE
> clause of the SQL Statement) so that it can be written to the delta file by
> the update/delete (sink) operators.
> The parser will add this column to the projection list to make sure it's
> passed along.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
