----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23320/#review49832 -----------------------------------------------------------
Looks better technically, just some minor style and cleanup comment below. I also think the new conf's description can be improved as per Lefty's suggestion. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/23320/#comment87220> Fix ws metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/23320/#comment87214> It can still be final even if static. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/23320/#comment87213> Doesnt look like these methods are used? service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/23320/#comment87215> End-paren should go on next line service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/23320/#comment87217> Can we move the javadoc to before annotation? service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java <https://reviews.apache.org/r/23320/#comment87218> We can refer to the map variable here. - Szehon Ho On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23320/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 4:11 p.m.) > > > Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas > Nair. > > > Bugs: HIVE-7353 > https://issues.apache.org/jira/browse/HIVE-7353 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7353 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ff282c5 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 760777a > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443 > service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > de54ca1 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > b39d64d > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > c2f0495 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > b009a88 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > be2eb01 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > 98d75b5 > > service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java > PRE-CREATION > > service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23320/diff/ > > > Testing > ------- > > Manual testing using Yourkit. > > > Thanks, > > Vaibhav Gumashta > >
