> On Aug. 6, 2014, 4:34 a.m., Harish Butani wrote: > > branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, > > line 9548 > > <https://reviews.apache.org/r/24337/diff/1/?file=652347#file652347line9548> > > > > do we need to remove the check for create view statements. > > Otherwise lgtm.
yeah.. you are right. Thats not required. Removed it. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24337/#review49693 ----------------------------------------------------------- On Aug. 5, 2014, 8:16 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24337/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 8:16 p.m.) > > > Review request for hive, John Pullokkaran and Harish Butani. > > > Bugs: HIVE-7619 > https://issues.apache.org/jira/browse/HIVE-7619 > > > Repository: hive > > > Description > ------- > > Enable views when cbo is on > > > Diffs > ----- > > > branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1615993 > branches/cbo/ql/src/test/queries/clientpositive/cbo_correctness.q 1615993 > branches/cbo/ql/src/test/results/clientpositive/cbo_correctness.q.out > 1615993 > > Diff: https://reviews.apache.org/r/24337/diff/ > > > Testing > ------- > > Added new tests. > > > Thanks, > > Ashutosh Chauhan > >
