-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24195/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 9:50 p.m.)
Review request for hive.
Changes
-------
Hi Brock,
Thanks for the suggestions! I've updated the diff. Please have a look. :)
Bugs: HIVE-7561
https://issues.apache.org/jira/browse/HIVE-7561
Repository: hive-git
Description
-------
Hive uses the "assert" keyword all over the place. The problem is that
assertions are rarely enabled since they have to be specifically enabled. In
the Spark code, e.g. GenSparkUtils, let's use Preconditions.*.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java
8c58333
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 25eea14
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java ceb7b6c
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java
3a0f4c9
ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java 86d14f1
Diff: https://reviews.apache.org/r/24195/diff/
Testing
-------
Thanks,
Chao Sun
