> On Aug. 1, 2014, 8:23 p.m., Thejas Nair wrote: > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 379 > > <https://reviews.apache.org/r/24170/diff/1/?file=647602#file647602line379> > > > > do we need to have "Exception" class in the throws ? > > Shims.doAs() throws IOException, InterruptedException > > Jason Dere wrote: > Will fix this.
Ok, now I remember why I originally had it throwing Exception - the methods that Shims.checkFileAccess() calls end up throwing lots of different kinds of exceptions, which makes the declaration for checkFileAccess() a bit unwieldy. Shims doesn't have access to any of the Hive exceptions to wrap these exceptions. I think it's better to just document the important ones (IOException/AccessControlException), and the rest of the exceptional cases get lumped in as Exception. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24170/#review49375 ----------------------------------------------------------- On Aug. 1, 2014, 12:54 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24170/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 12:54 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-7583 > https://issues.apache.org/jira/browse/HIVE-7583 > > > Repository: hive-git > > > Description > ------- > > Create shims method to either use new FileSystem.access() API, or fall back > to Hive implementation of file access checks. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 8dcd4cf > > itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProviderWithACL.java > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java > 97fb7ba > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProvider.java > 223f155 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java > f803cc4 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java > 6a283ab > shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > d03f270 > shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java > e98b54d > > shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java > 605ea55 > shims/common/src/main/java/org/apache/hadoop/fs/DefaultFileAccess.java > PRE-CREATION > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > eefd5e5 > > Diff: https://reviews.apache.org/r/24170/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
